Allow inheriting LayerFilter to customize filter behavior. #390
+431
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
requested review from
kevingpqi123,
domchen,
lvpengwei and
shlzxjp
as code owners
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
reviewed
Dec 19, 2024
domchen
changed the title
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
domchen
reviewed
Dec 20, 2024
…partyhuang_layerFilter # Conflicts: # test/baseline/version.json resolved by e5ca671 version
domchen
reviewed
Dec 20, 2024
src/layers/Layer.cpp
Outdated
Comment on lines
537
to
550
| std::shared_ptr<Image> Layer::createPictureImage(std::shared_ptr<Picture> picture, Point* offset) { | ||
| if (picture == nullptr) { | ||
| return nullptr; | ||
| } | ||
| auto bounds = picture->getBounds(); | ||
| bounds.roundOut(); | ||
| auto matrix = Matrix::MakeTrans(-bounds.x(), -bounds.y()); | ||
| auto image = Image::MakeFrom(std::move(picture), static_cast<int>(bounds.width()), | ||
| static_cast<int>(bounds.height()), &matrix); | ||
| if (offset) { | ||
| *offset = Point::Make(bounds.x(), bounds.y()); | ||
| } | ||
| return image; | ||
| } |
There was a problem hiding this comment.
这个加个静态函数是不是就行了？没有访问任何layer的属性。
domchen
reviewed
Dec 20, 2024
src/layers/Layer.cpp
Outdated
| return image; | ||
| } | ||
|
|
||
| std::shared_ptr<Picture> Layer::getLayerContents(const DrawArgs& args, float contentScale) { | ||
| if (FloatNearlyZero(contentScale)) { | ||
| return nullptr; | ||
| } | ||
| Recorder recorder; | ||
| Recorder recorder{}; |
There was a problem hiding this comment.
是 Recorder recorder = {}; 编译器会优化成只有一次构造函数调用的。
domchen
reviewed
Dec 20, 2024
| } | ||
| return lastFilter; | ||
| Paint paint; |
domchen
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.