Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(affix): improve Affix component and tests #3270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Dec 6, 2024

  • optimize environment judgment
  • correctly judge whether parameters are passed in

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • test(affix): 添加测试用例并修复判断距离容器位置参数是否传入

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

- optimize environment judgment
- correctly judge whether parameters are passed in
Copy link
Contributor

github-actions bot commented Dec 6, 2024

完成

@RSS1102
Copy link
Contributor Author

RSS1102 commented Dec 6, 2024

  1. vitest 的运行环境下,是仍然能判断到 window 存在的。
_17334862182587
  1. 因为 https://github.com/Tencent/tdesign-react/blob/develop/src/affix/Affix.tsx#L18 会创建默认值0, 则原有判断参数是否传入永远无效。

@RSS1102
Copy link
Contributor Author

RSS1102 commented Dec 7, 2024

在项目中 我使用 `import ..... from '@/test/utils'; 并不能获得类型提示

但是我是用 import ..... from '../../../test/utils 可以
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant