Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-picker): coloerInstanceRef value is not updated, causing re-render problems #3242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(color-picker): coloerInstanceRef value is not updated, causing re-render problems #3242

wants to merge 1 commit into from

Conversation

huangchen1031
Copy link
Collaborator

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3120
Tencent/tdesign-common#1962

💡 需求背景和解决方案

useRef缓存导致state和ref保存的颜色未同步，引发的一系列问题

📝 更新日志

  • fix(color-picker): 修复innerValue和colorInstanceRef不同步导致的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@huangchen1031 huangchen1031 reopened this Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

完成

@uyarn
Copy link
Collaborator

uyarn commented Dec 2, 2024

@HaixingOoO 一起看看这个

@HaixingOoO
Copy link
Collaborator

@HaixingOoO 一起看看这个

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaixingOoO HaixingOoO HaixingOoO approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@NWYLZW NWYLZW Awaiting requested review from NWYLZW NWYLZW is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangchen1031 @uyarn @HaixingOoO