-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: example of skyline page with collapse component removed #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 234 kB ℹ️ View Unchanged
|
betavs
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
背景:组件示例小程序中, collapse 组件示例动画失效
复现路径
开启 "disableABTest": true 配置项,test 页面未开启 skyline,index页面开启 skyline。
将 test 页面作为组件引入 index 页面,并从home页面直接跳转到test页面,test 页面会开启 skyline。
代码片段
https://developers.weixin.qq.com/s/rcqEgZmO7mVJ
原因:
componentFramework 和 renderer 会沿 usingComponents 递归向下传递。 导致 pages/collapse/collapse 页面开启 skyline,而该组件并未适配 skyline render。
方案
移除 pages/collapse/skyline/collapse 页面