-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Navbar): Fixed getRect caused navbar position to be inaccurate #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +85 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
1 similar comment
Size Change: +85 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
anlyyao
force-pushed
the
fix/navbar/rect
branch
from
November 27, 2024 04:42
51ea1a2
to
bebd2a2
Compare
anlyyao
force-pushed
the
fix/navbar/rect
branch
from
November 27, 2024 04:43
bebd2a2
to
cbc7d0d
Compare
Size Change: -35 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
Size Change: -36 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
Size Change: -56 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
Size Change: -65 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
1 similar comment
Size Change: -65 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
anlyyao
reviewed
Nov 28, 2024
Size Change: +35 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
betavs
force-pushed
the
fix/navbar/rect
branch
from
November 28, 2024 06:54
0f41fae
to
fde5c2f
Compare
Size Change: -51 B (0%) Total Size: 234 kB
ℹ️ View Unchanged
|
anlyyao
approved these changes
Nov 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #3302
💡 需求背景和解决方案
问题点:
📝 更新日志
fix(Navbar): 修复
getRect
耗时过长导致navbar
位置不准确问题,并兼容部分机型因精度问题导致的翻译功能完成后标题仍然隐藏的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单