Skip to content

Commit

Permalink
BRK: Use PackageTitle instead of Title as NuGet package title
Browse files Browse the repository at this point in the history
  • Loading branch information
rdeago committed Nov 9, 2023
1 parent f928b33 commit b57564e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- The change in version 1.0.106-preview, whereas the `Title` property was used as a default for `AssemblyTitle`, has been reversed. It turns out that the order in which MSBuild loads Buildvana.Sdk in relation to Microsoft.NET.Sdk makes the change ineffective.
- The default value for property `AppFullName`, used as a constant passed to InnoSetup, is now `$(AssemblyTitle)` instead of `$(Title)`.
- **BREAKING CHANGE**: The property used as NuGet package title is now `PackageTitle` instead of `Title`. If left unset, it defaults to `$(AssemblyTitle)`.

### Bugs fixed in this release

Expand Down
7 changes: 6 additions & 1 deletion src/Buildvana.Sdk/Modules/NuGetPack/NuspecFile.targets
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@
<SourceRevisionId Condition="'$(SourceRevisionId)' == ''">0</SourceRevisionId>
</PropertyGroup>

<!-- PackageTitle defaults to AssemblyTitle -->
<PropertyGroup>
<PackageTitle Condition="'$(PackageTitle)' == ''">$(AssemblyTitle)</PackageTitle>
</PropertyGroup>

<PropertyGroup>
<NuspecProperties>
minClientVersion=$(MinClientVersion);
id=$(PackageId);
title=$(Title);
title=$(PackageTitle);
version=$(PackageVersion);
summary=$(Summary);
description=$(Description);
Expand Down

0 comments on commit b57564e

Please sign in to comment.