Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): esim and funnel icons #874

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(icons): esim and funnel icons #874

merged 1 commit into from
Sep 7, 2023

Conversation

yceballost
Copy link
Contributor

@yceballost yceballost commented Sep 5, 2023

The 98% of changes are caused by Figma instability with svgs. Nothing important.

The real changes is: Added funnel and esim icons to Telefónica set (in 3 weights)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real change

Copy link
Contributor Author

@yceballost yceballost Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change to be committed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is be safe to commit but I don't know what produced this change.

This file is updated when you change dependencies

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Size stats

master this branch diff
Total JS 9.46 MB 9.47 MB +5.86 kB
JS without icons 961 kB 961 kB 0 B
Lib overhead 125 kB 125 kB 0 B
Lib overhead (gzip) 32.2 kB 32.2 kB 0 B

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-719jm6v8e-tuentisre.vercel.app

Built with commit a5ada69.
This pull request is being automatically deployed with vercel-action

@yceballost yceballost linked an issue Sep 5, 2023 that may be closed by this pull request
2 tasks
@yceballost yceballost marked this pull request as ready for review September 5, 2023 11:56
@atabel atabel changed the title New esim and funnel icons fix(icons): esim and funnel icons Sep 7, 2023
@atabel atabel added this pull request to the merge queue Sep 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2023
@atabel atabel added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit ed39d6d Sep 7, 2023
10 checks passed
@atabel atabel deleted the funnel-esim-icons branch September 7, 2023 14:37
tuentisre pushed a commit that referenced this pull request Sep 11, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-09-11)

### Bug Fixes

* **AdvancedDataCard:** fix hover on actions removing hover on card ([#876](#876)) ([742a9d2](742a9d2))
* **DateTimeField:** add default value for max ([#873](#873)) ([1bd25a7](1bd25a7))
* **Form:** set mountedRef value to true on client side first render ([#863](#863)) ([68f7f99](68f7f99))
* **icons:** esim and funnel icons ([#874](#874)) ([ed39d6d](ed39d6d))
* **Inline:** avoid content overflow with wrap and negative space ([#872](#872)) ([5c7f89f](5c7f89f))
* **OverscrollColor:** add provider to storybook and fix possibly undefined height ([#879](#879)) ([f2d7edf](f2d7edf))
* **ProgressBlock:** fix undefined check when progressPercent is 0 ([#862](#862)) ([abce1cf](abce1cf))

### Features

* **getCssVarValue:** utility function ([#877](#877)) ([1fd0d3e](1fd0d3e))
* **Logo:** update component, story and screenshot tests ([#875](#875)) ([556a9f0](556a9f0))
* **showSheet:** fallback to web implementation when native one fails ([#860](#860)) ([8741a28](8741a28))
* **Text:** support textAlign right ([#878](#878)) ([9cdc6b7](9cdc6b7))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New chip esim and funnel icons
5 participants