Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-15206 Set icon as null when there is no icon #387

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jeslat
Copy link
Contributor

@jeslat jeslat commented Sep 19, 2024

🥅 What's the goal?

Set icon as null when there is no icon. Due to this, the left padding was wrong in the compose list row item because we were adding an extra space because the icon was not null.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.

🧪 How can I test this?

Before After
drawing drawing

@jeslat jeslat requested review from a team, yceballost, dpastor and juangardi21 and removed request for a team September 19, 2024 12:45
Copy link

📱 New catalog for testing generated: Download

@@ -293,6 +293,10 @@ fun ListRowItemPreview() {
MisticaTheme(brand = MovistarBrand) {
val checkedState = remember { mutableStateOf(true) }
Column {
ListRowItem(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the preview to add this case

Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jeslat jeslat merged commit 44d6ab7 into main Sep 23, 2024
5 checks passed
@jeslat jeslat deleted the ANDROID-15206-wrong-padding branch September 23, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants