ANDROID-13311 Evolve Feedback Screen #300
Conversation
|
📱 New catalog for testing generated: Download |
jeslat
requested review from
a team,
dpastor,
jdelga,
jeprubio and
AnaMontes11
and removed request for
a team and
dpastor
library/src/main/java/com/telefonica/mistica/feedback/screen/view/FeedbackScreenView.kt
Outdated
Show resolved
Hide resolved
@jeprubio the compose implementation is just a wrapper of the XML view so no need to change anything |
|
📱 New catalog for testing generated: Download |
There was a problem hiding this comment.
We have informed Vivo about the internal margin of the icon, which causes it to appear misaligned with the text and smaller in size. Additionally, there is an issue with the size of the Lottie animation that was detected by @jeslat. Vivo has informed us that they are preparing the correct assets. We are still waiting for them to provide us with these assets so that we can include them.
You can provide more context here: https://jira.tid.es/browse/OBVIVO-1792
| android:layout_marginTop="24dp" | ||
| android:scaleType="center" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| android:layout_height="48dp" |
There was a problem hiding this comment.
I understand that the icon is at 48, and that's correct, but even with the internal margin we discussed earlier, it still appears visually too small. Is it possible for the icon to scale according to the screen density?
There was a problem hiding this comment.
That 48dp, the dp in there means density-independent pixels so it's scaling according to screen density. I suspect the feedback_success_vivo_new.json has some margins in it so then when the height are set to 48dp it has to be shrunk to fit in there, I would check that.
|
📱 New catalog for testing generated: Download |
Hi @AnaMontes11 This new catalog includes the new lottie asset for Vivo New. How about now? 🙂 
|
🥅 What's the goal?
Evolve Feedback Screen:
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?
You can use the generated catalog to see all the different combinations due to in some cases, the icon/animation changes per brand.
Video with the feedbacks in Vivo-New and the new animations:
feedback-vivonew.mp4