Refactoring-Layout #4
Conversation
…ales into refactoring-ui
Apply Sweep Rules to your PR?
|
Fixing PR: track the progress here.I'm currently fixing this PR to address the following: [Sweep GHA Fix] The GitHub Actions run failed with the following error logs:
An error has occurred: Message is too long, max tokens is -24876 (tracking ID: eab85d1b13) |
|
🚀 Expo preview is ready!
|
There was a problem hiding this comment.
I have left some comments to fix performance.
There are a bunch of consistency issues in the code in terms of style, use of direct deserialisation (no zod), different setting used for the UI and the cloudflare worker, etc.
Given this project is needed to be shipped asap, we will ignore those minor issues.
Hope this apk works
worker-turso-ts/src/index.ts
Outdated
|
|
||
| router.get('/tasks', async () => { | ||
| const client = buildLibsqlClient(env); | ||
| const rs = await client.execute('select * from tasks'); |
There was a problem hiding this comment.
select * from tasks where assigned_to is me
worker-turso-ts/src/index.ts
Outdated
| function buildRouter(env: Env): RouterType { | ||
| const router = Router(); | ||
|
|
||
| router.get('/tasks', async () => { |
There was a problem hiding this comment.
it must be passed a phone number! (the number of the mobile of the sales agent)
There was a problem hiding this comment.
You will need to add a UI to get the user's phone number. Just put it in a settings tab
|
updates here? @Naveen-g09 |
|
Tried, multiple builds |
There was a problem hiding this comment.
@sutyum sir can you check why POST is not working even though I tried setting up CORS in cloudFlare workers.
In terms of other works This PR is ready
- tasks are being fetched from database
- Call logs are shown based on filtering
- Number and Duration are shown
Issues:
- No POST Requests to database
|
@PrinceBaghel258025 I will be back by 5, please help me to finish it |
|
This app gives the list of Clients to call, and fetches its logs from mobile There is a settings page modal, which will save user number which will be his identity and it should fetch calls assigned to him Issues:
I will refactor the UI. please pull the latest commit of this branch additionally: |
Set pull to refresh
Set auto refresh every 30 seconds