Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comments): add creator reply field #718

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

FineFindus
Copy link
Contributor

Adds support for a new API field when the video creator has replied to a comment. For example, YouTube will show it as the creator's profile picture next to the number of comments.

Builds on TeamNewPipe/NewPipeExtractor#1111 and is marked as a draft until a new release of NewPipeExtractor includes it.
The changes are also currently untested, I will test (and update if necessary) as soon as a new version is released.

YouTube comment with an answer and the creator's thumbnail next to it

@FireMasterK FireMasterK mentioned this pull request Oct 10, 2023
@FireMasterK
Copy link
Member

Hi, just merged a PR to update the NPE fork we use, we don't need to wait for a release :)

@FineFindus FineFindus force-pushed the feat/comment-creator-reply branch from 87ffddf to 3a1ea8b Compare October 11, 2023 14:32
@FineFindus FineFindus marked this pull request as ready for review October 11, 2023 14:33
Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FireMasterK FireMasterK merged commit 2a9055d into TeamPiped:master Oct 11, 2023
8 checks passed
@FineFindus FineFindus deleted the feat/comment-creator-reply branch October 11, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants