[YT] Fix "Could not get like count" #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. YT uses a different data structure for likes (ViewModels instead of Renderers) 2. Fixed NPE in old code due to incorrect usage of string comparison 3. Unified JSONObject filtering and mapping
|
Hi @litetex, glad to see you again on NewPipe repos 🎉 Unfortunately, your PR is a "duplicate" of one previously closed: #1123. I am closing your PR for the same reason as my comment on this PR. Don't hesitate to let me know what you think of my changes! As YouTube seems now to roll out this change, I will change my changes in #1127 to try to use the new structure first soon. Thank you for time and sorry to close your PR :( |
AudricV
added
the
duplicate
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1133
New data structure looks like this