Added support for Jinja2 3.1.2 and scikit-learn 1.0.2 #418
Conversation
…s occurred: Jinja2 3.1.2 AttributeError: module 'jinja2.ext' has no attribute 'with_' scikit-learn 1.0.2 ModuleNotFoundError: No module named 'sklearn.metrics.scorer' ModuleNotFoundError: No module named 'sklearn.feature_selection.base' The changes in 'html.py', 'permutation_importance.py' and 'transform.py' are such that these errors are resolved while maintaining support for older versions of jinja2 and scikit-learn. 'test_import.py' is used to test importing eli5 for both newer and older dependency versions.
There was a problem hiding this comment.
Hi @dvorst , thanks for the fixes 👍 I didn't run the tests but changes look good to me, left one comment below. However, would you mind submitting the PR against https://github.com/eli5-org/eli5/, if you don't mind?
| if version.parse(jinja2.__version__) <= version.parse('3.0.3'): | ||
| raise ImportError('module "Jinja2" must be of a later version than "3.0.3".') | ||
| if version.parse(sklearn.__version__) < version.parse('1.0.2'): | ||
| raise ImportError('module "Jinja2" must be version "1.0.2" or later.') |
There was a problem hiding this comment.
What is the goal of these checks? From the code above it seems that we do support older versions of these libraries? If we want to work only with versions specified here, it's better to specify this in setup.py.
There was a problem hiding this comment.
Yeah, the test file is probably not really needed, I omitted it and also slightly changed some other stuff in the PR for https://github.com/eli5-org/eli5/ (the sklearn issue for example was already resolved)
|
Can we get a merge ASAP on this? ELI5 is now broken for most use-cases since you know, most people are running this on sklearn models... Also breaks my HF space: https://huggingface.co/spaces/Hellisotherpeople/Interpretable_Text_Classification_And_Clustering |
|
@Hellisotherpeople this was merged in eli5-org/eli5#19 and released in 0.12, thanks for a reminder |
When using Jinja2 3.1.2 and scikit-learn 1.0.2, the following errors occurred:
The changes in 'html.py', 'permutation_importance.py' and 'transform.py' are such that these errors are resolved while maintaining support for older versions of jinja2 and scikit-learn.
'test_import.py' is used to test importing eli5 for both newer and older dependency versions.
Also see: #417