-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Keras images) Add an optional image argument, and other improvements #329
Merged
Merged
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c4eb039
(keras) Make image argument required
teabolt 1111105
Update README.md to include keras
teabolt 7d6d982
Merge branch 'master' of https://github.com/teabolt/eli5 into keras-g…
teabolt 14452c3
Remove mentions of target_names (not implemented)
teabolt 9e85021
Add dispatch function and image implementation
teabolt 9a0cd53
Update dispatcher and image function docstrings
teabolt 6b002a6
Automatically check if model/input is image-based. Convert input to a…
teabolt 7d82c30
Mock keras.preprocessing.image in docs conf (CI fix)
teabolt d1af643
Update tests, docs, tutorial with image argument changes
teabolt 6aec486
Blank line between header and list in docstring (CI fix)
teabolt aaa83a7
Test keras not supported function
teabolt 47b03c1
Docstring typo
teabolt df25038
Clarify "not supported" error message.
teabolt 6234aaa
Remove TODO: explain Grad-CAM in docstring. (Will be explained in ker…
teabolt 13e1847
Move image extraction call from dispatcher to image function
teabolt 3e875bb
Move Keras to second place in supported package list
teabolt 4192939
Remove warnings for 'maybe image' dispatch and conversion to RGBA
teabolt 2bb7ba5
'not supported' error typo
teabolt 991159b
Test 'maybe image' check with both input and model
teabolt 10921be
Add Grad-CAM image to README
teabolt 0cf31fe
Remove line breaking backslash from docstring
teabolt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+116 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_15_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_19_0.png
Binary file not shown.
Binary file added
BIN
+112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_21_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-110 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_22_0.png
Binary file not shown.
Binary file modified
BIN
-5.83 KB
(95%)
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_24_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-116 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_24_1.png
Binary file not shown.
Binary file added
BIN
+116 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_26_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+116 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_26_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-119 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_29_1.png
Binary file not shown.
Binary file removed
BIN
-114 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_29_3.png
Binary file not shown.
Binary file removed
BIN
-112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_29_5.png
Binary file not shown.
Binary file added
BIN
+119 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_31_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+114 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_31_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+111 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_31_5.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-116 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_39_0.png
Binary file not shown.
Binary file modified
BIN
+116 KB
(100000%)
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_41_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-337 Bytes
(26%)
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_43_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-112 KB
(0.40%)
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_45_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_47_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-109 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_48_0.png
Binary file not shown.
Binary file added
BIN
+109 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_50_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_51_1.png
Binary file not shown.
Binary file removed
BIN
-112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_51_3.png
Binary file not shown.
Binary file added
BIN
+112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_53_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_53_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_54_1.png
Diff not rendered.
Binary file removed
BIN
-114 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_54_3.png
Diff not rendered.
Binary file added
BIN
+112 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_56_1.png
Oops, something went wrong.
Binary file added
BIN
+114 KB
...ource/_notebooks/keras-image-classifiers_files/keras-image-classifiers_56_3.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it look more 😎 we may move Keras upper the list, e.g. right after scikit-learn (both here and in overview); it can be easy to miss otherwise, as with lightning / sklearn-crfsuite the list starts to be a bit obscure.