Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-248 #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GH-248 #249

wants to merge 1 commit into from

Conversation

sharthZ23
Copy link

I think, this will fix #248
Can't run tests, because in my version of xgboost xgb.booster() must be replaced by xgb.get_booster()

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #249 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   97.22%   97.22%   +<.01%     
==========================================
  Files          44       44              
  Lines        2813     2814       +1     
  Branches      535      535              
==========================================
+ Hits         2735     2736       +1     
  Misses         41       41              
  Partials       37       37
Impacted Files Coverage Δ
eli5/xgboost.py 99.38% <100%> (ø) ⬆️

@gabrielelanaro
Copy link

Any chance this pull request will be merged? This is quite an important bug

@lopuhin
Copy link
Contributor

lopuhin commented Jan 11, 2018

Sorry for slow feedback @sharthZ and @gabrielelanaro , I think there are two items preventing the merge:

  • it would be nice to add a test to this PR that checks that this does fix the issue with boolean attributes
  • unrelated to this PR: unfortunately, eli5 does not work with xgboost 0.7 at the moment which causes tests to fail, so in order to run them we need to either pin xgboost to <0.7 temporary in tests, or to fix the issues with xgboost 0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Line in unexpected format
4 participants