Linted #29
Merged
Linted #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files to review: src/main/java/com/team766/web/AutonomousSelector.java src/main/java/com/team766/hal/wpilib/CANSparkMaxMotorController.java
using checkstyle with modified sun microsystems linter rules
rcahoon
reviewed
Jul 28, 2023
rcahoon
reviewed
Jul 28, 2023
There was a problem hiding this comment.
It occurs to me that all of the method parameters that were renamed to "...Param" will make the argument name hints in VSCode uglier. I support enforcing that method parameters have a different name than class member variables, but maybe there's a better naming scheme that we could use
src/main/java/com/team766/hal/wpilib/BaseCTRESpeedController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANSparkMaxMotorController.java
Outdated
Show resolved
Hide resolved
rcahoon
reviewed
Aug 14, 2023
switch to _ instead of Param
rcahoon
reviewed
Aug 14, 2023
rcahoon
reviewed
Aug 14, 2023
rcahoon
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linted maroon framework and relaxed rules because linting isn’t fun
This change is