Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up common DriverOI #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clean up common DriverOI #80

wants to merge 1 commit into from

Conversation

dejabot
Copy link
Contributor

@dejabot dejabot commented Mar 11, 2024

Description

Fix some changes I missed from the version of this in the original branch introducing OIFragment:

  • DriverOI should update several member variables (leftJoystickX, etc) in handlePre vs handleOI.
  • handleOI should be protected

How Has This Been Tested?

Needs testing on RevA.

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qntmcube qntmcube qntmcube approved these changes

@rcahoon rcahoon rcahoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dejabot @rcahoon @qntmcube