Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INIT] DB 설정 정보 추가 #18

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[INIT] DB 설정 정보 추가 #18

merged 4 commits into from
Jan 9, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 8, 2024 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

  • application-dev(공개용)과 application-secret(보안용)을 분리했습니다.
  • secret 파일은 깃허브 내 시크릿 키에 업로드 해두었습니다. 세부 내용은 개별적으로 공유 드리겠습니다.
  • application 파일을 분리함에 따라 CI 일부 수정했습니다. 이 부분 담당한 승빈님이 맞는 지 봐주시면 감사하겠습니다!

@thguss thguss added sohyeon 소현 작업 init 초기 설정 labels Jan 8, 2024
@thguss thguss requested review from csb9427 and Chan531 January 8, 2024 21:35
@thguss thguss self-assigned this Jan 8, 2024
csb9427
csb9427 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했습니다 고생하셨어요~~

.github/workflows/CI.yml
echo "${{ secrets.APPLICATION }}" > ./application.yaml
echo "${{ secrets.APPLICATION_SECRET_YML }}" > ./application-secret.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 확인했습니다

Chan531
Chan531 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~! 수고하셨습니다!!

@thguss thguss merged commit 8d127ec into develop Jan 9, 2024
1 check passed
@thguss thguss deleted the feature/#16-db-init branch January 9, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

@csb9427 csb9427 csb9427 approved these changes

Assignees

@thguss thguss

Labels
init 초기 설정 sohyeon 소현 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INIT] 데이터베이스 세팅
3 participants
@thguss @csb9427 @Chan531