Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add useScrollendEvent option #875

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix: add useScrollendEvent option #875

merged 3 commits into from
Nov 7, 2024
+37 −22

Conversation

hshoja
Copy link
Contributor

@hshoja hshoja commented Nov 6, 2024

fixes #799

piecyk
piecyk reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@piecyk piecyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also update dosc regarding this new option.

packages/virtual-core/src/index.ts Outdated Show resolved Hide resolved
packages/virtual-core/src/index.ts Outdated Show resolved Hide resolved
@hshoja hshoja marked this pull request as ready for review November 6, 2024 14:14
@hshoja hshoja requested a review from piecyk November 6, 2024 14:15
@hshoja hshoja force-pushed the fix/addExplicitDebounceFallback branch from 720fe45 to ee4fbcb Compare November 6, 2024 14:17
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 85604b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 6, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@875

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@875

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@875

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@875

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@875

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@875

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@875

commit: 85604b0

@hshoja hshoja force-pushed the fix/addExplicitDebounceFallback branch from ee4fbcb to a7effba Compare November 6, 2024 15:29
@piecyk piecyk changed the title fix: add explicit debounce fallback fix: add useScrollendEvent option Nov 7, 2024
@hshoja hshoja requested a review from piecyk November 7, 2024 10:19
@piecyk piecyk merged commit 375cd83 into TanStack:main Nov 7, 2024
5 checks passed
@piecyk
Copy link
Collaborator

piecyk commented Nov 7, 2024

Thanks @hshoja 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piecyk piecyk piecyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional scroll events after scrollend causes isScrolling to remain true
2 participants
@hshoja @piecyk