Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve RedirectVersionBanner malfunction #321

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix: Resolve RedirectVersionBanner malfunction #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1bb6b
Fix: Resolved an issue where RedirectVersionBanner redirected to the …
hyeongrok7874 Dec 20, 2024
02ca327
Merge branch 'main' into fix/RedirectRecentVersionBanner
tannerlinsley Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/components/RedirectVersionBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { useLocalStorage } from '~/utils/useLocalStorage'
import { useClientOnlyRender } from '~/utils/useClientOnlyRender'
import { Link } from '@tanstack/react-router'
import { Link, useMatches } from '@tanstack/react-router'

export function RedirectVersionBanner(props: {
version: string
latestVersion: string
}) {
const { version, latestVersion } = props

const matches = useMatches()
const activeMatch = matches[matches.length - 1]

// After user clicks hide, do not show modal for a month, and then remind users that there is a new version!
const [showModal, setShowModal] = useLocalStorage(
'showRedirectToLatestModal',
Expand All @@ -25,6 +28,7 @@ export function RedirectVersionBanner(props: {
<p className="block">
You are currently reading <strong>{version}</strong> docs. Redirect to{' '}
<Link
to={activeMatch.fullPath}
params={{
version: 'latest',
}}
Expand All @@ -36,6 +40,7 @@ export function RedirectVersionBanner(props: {
</p>
<div className="flex gap-2 flex-col lg:flex-row items-center">
<Link
to={activeMatch.fullPath}
params={{
version: 'latest',
}}
Expand Down