fix: Adjust markdown links to correct level #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, markdown links are written in a way that is compatible with tanstack.com, but not with native markdown navigation.
For example: https://github.com/TanStack/query/blob/13817e953743537ffb9aab4da174583055be4d81/docs/framework/react/overview.md?plain=1#L99
Clicking either of these links will fail if you navigate on GitHub or in your IDE.
Solution
If we write the docs using correct markdown links, we can use regex on tanstack.com to correct the path:
([A-Za-z][A-Za-z/_-]+)
matches group 1 starting with a letter, then optionally also containing/
,-
or_
.md
matches the markdown extension outside the group (existing links will NOT break as they do not have.md
)../$1
prefixes group 1 with../
For example, this rewrites
reference/FormApi.md
to../reference/FormApi
This even works for something like
./reference/FormApi.md
, which gets rewritten to./../reference/FormApi
but still correctly routes on tanstack.com.