fix: headings collapsing when there is no content to separate them #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SeanCassiere
commented
Jun 17, 2024
KevinVandy
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all headings extracted from the markdown files are wrapped in anchor tags.
Since anchor tags have a display property of
inline, when there are adjacent headings and no content to separate them, it causes the headings to collapse onto one another into a single line. See the screenshot below.The easiest fix for this, without having to use specific CSS selectors, is to set the
display: grid;on the outer block containing the markdown content. This fixes the bug and restores order to world 🙌🏼. See the screenshot below.