-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derived Stores #40
base: main
Are you sure you want to change the base?
Derived Stores #40
Conversation
c0c0d1c
to
790303c
Compare
Woo! 🏎️ |
Angular is the fastest, nice 😄! |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cc45169. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Out of curiosity, what's the state of this PR and what's stopping it from being reviewed/merged? |
+1 |
# Conflicts: # .eslintrc.cjs # knip.json # package.json # packages/solid-store/package.json # packages/store/package.json # packages/store/src/index.ts # packages/store/src/tests/index.test.tsx # packages/store/tests/derived.bench.ts # packages/store/tests/derived.test.ts # packages/store/tests/effect.test.ts # packages/store/tests/index.test.tsx # packages/store/tests/store.test.ts # packages/vue-store/package.json # pnpm-lock.yaml
This PR implements an initial
Derived
class implementation:Note
This API of
mount
seems wonky for application use because, well, it is. It's intended for other libraries like TanStack Form and TanStack Table's internals.We may introduce a more application-friendly
Derived
andEffect
API for usage in apps, but it's not clear yet what that looks like. Please feel free to jump into the discussion here for moreTODO
Derived State
that includesprevVal
andprevVals
Derived
to make sure it continues to workDerived
/Effect
's side effects to explicitmount
andunmount
methodspreviousValues
toDerived
Edgecase Handling
This Derived implementation even solves the diamond problem:
Where writes to "a" will call "d" twice (with a flicker of incorrect data known as a "Glitch") because of the dual-derived nature. Our implementation does not have this problem and therefore can be considered "glitch-free"
This is a push-based/hot signals implementation
Benchmarks
Due to the relatively naive nature of this code (I wrote it in one night at ~midnight) there are performance implication in using this. Namely, in our benchmarks we are a far cry from Angular or Solid's implementation, but come close to Vue's implementation: