Angular persist query client experimental #8324

OmerGronich · 2024-11-22T14:57:03Z

Angular Query Persister Plugin

Created angular-query-persist-client-package
Implemented withPersistQueryClient in new package
Added isRestoring provider and injection token to main angular-query package

nx-cloud · 2024-11-22T15:41:01Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d80309. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3`

✅ Successfully ran 1 target

nx run-many --target=build --exclude=examples/** --exclude=integrations/**

Sent with 💌 from NxCloud.

arnoud-dv

Some suggestions for now, I still need to do a more in-depth review of the persistence itself.

examples/angular/basic-persister/.devcontainer/devcontainer.json

examples/angular/basic-persister/package.json

examples/angular/basic-persister/src/app/app.config.ts

examples/angular/basic-persister/src/index.html

examples/angular/basic-persister/tsconfig.json

packages/angular-query-experimental/src/inject-is-restoring.ts

- Created isRestoring injection token and provider - handled restoration phase in create-base-query.ts - handled restoration phase in

…port, and the withPersistQueryClient feature

…r migration

This reverts commit af5b47b.

Co-authored-by: Arnoud <[email protected]>

…tes how to selectively persist queries to different persisters.

…ry-client-experimental # Conflicts: # packages/angular-query-experimental/src/create-base-query.ts

…ry-client-experimental

…e React adapter logic

…match the React adapter logic" This reverts commit 235bbab.

github-actions bot added the package: angular-query-experimental label Nov 22, 2024

OmerGronich marked this pull request as draft November 22, 2024 14:58

OmerGronich force-pushed the angular-persist-query-client-experimental branch from 8474149 to 31c8c0e Compare November 22, 2024 15:01

OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 0ff5f5c to b4d880a Compare November 23, 2024 12:00

OmerGronich closed this Nov 23, 2024

OmerGronich deleted the angular-persist-query-client-experimental branch November 23, 2024 12:00

OmerGronich restored the angular-persist-query-client-experimental branch November 23, 2024 12:00

OmerGronich reopened this Nov 23, 2024

OmerGronich force-pushed the angular-persist-query-client-experimental branch from 566f72a to e1ae58d Compare November 23, 2024 19:42

OmerGronich marked this pull request as ready for review November 23, 2024 20:12

arnoud-dv self-assigned this Nov 26, 2024

OmerGronich force-pushed the angular-persist-query-client-experimental branch 2 times, most recently from d4fa95c to 9e4182a Compare November 29, 2024 13:27

arnoud-dv requested changes Dec 1, 2024

View reviewed changes

OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 3c3c8ec to ed0ed3c Compare December 7, 2024 14:40

OmerGronich added 10 commits December 7, 2024 22:44

feat(angular-query):

f327a5d

- Created isRestoring injection token and provider - handled restoration phase in create-base-query.ts - handled restoration phase in

feat(angular-query): created package for experimental persistence sup…

dd92bfc

…port, and the withPersistQueryClient feature

test(persistQuery): add tests for withPersistQueryClient

b8afd8a

docs(angular-query): add basic persister example

547ae9e

fix(angular-query): synced angular versions in new package

7130913

fix(angular-query): commit before ng update

5709184

feat(angular-query): updated example to v18

9e6ef24

fix(angular-query): fixed project name to basic-persister

962cf32

feat(angular-query): updated example basic-persister to v19

4d305a5

feat(angular-query): included back the persister package after angula…

630e462

…r migration

OmerGronich and others added 18 commits December 7, 2024 22:44

feat(angular-query): migrate to provideEnvironmentInitializer

fed1caa

fix(angular-query): fix eslint issues in inject-queries.ts

63831fb

Revert "feat(angular-query): migrate to provideEnvironmentInitializer"

059b620

This reverts commit af5b47b.

fix(angular-query): only track the isRestoring in the effect

05848e2

fix(angular-query): removed conditional _isRestoring

a0d3111

ci: apply automated fixes

e2f579b

fix(angular-query): used effect onCleanup instead of destroy ref

929b114

Update examples/angular/basic-persister/.devcontainer/devcontainer.json

9dcdd1c

Co-authored-by: Arnoud <[email protected]>

Update examples/angular/basic-persister/package.json

f208029

Co-authored-by: Arnoud <[email protected]>

Update examples/angular/basic-persister/src/index.html

1d3c67a

Co-authored-by: Arnoud <[email protected]>

Update examples/angular/basic-persister/tsconfig.json

db2b2a3

Co-authored-by: Arnoud <[email protected]>

Update examples/angular/basic-persister/tsconfig.json

de5b14f

Co-authored-by: Arnoud <[email protected]>

Update examples/angular/basic-persister/tsconfig.json

03b9c02

Co-authored-by: Arnoud <[email protected]>

Update packages/angular-query-experimental/src/inject-is-restoring.ts

67d3f38

Co-authored-by: Arnoud <[email protected]>

fix(angular-query): fixed lock file

b30b21b

fix(angular-query): aligned package.json versions

c9ec26a

added missing dep from basic-persister example

b858927

Added a more complex example for persistence. This examples demonstra…

325b2a7

…tes how to selectively persist queries to different persisters.

OmerGronich force-pushed the angular-persist-query-client-experimental branch from ed0ed3c to 325b2a7 Compare December 7, 2024 20:44

OmerGronich added 5 commits December 8, 2024 21:13

Merge remote-tracking branch 'upstream/main' into angular-persist-que…

c908304

…ry-client-experimental # Conflicts: # packages/angular-query-experimental/src/create-base-query.ts

fix(angular-query) bumped versions to 5.62.4

5da9025

refactor(angular-query) refactored to implicit return

36605e6

Merge remote-tracking branch 'upstream/main' into angular-persist-que…

a5f7942

…ry-client-experimental

fix(angular-query) bump angular persister package and examples version

5d80309

OmerGronich requested a review from arnoud-dv December 11, 2024 18:10

OmerGronich and others added 5 commits December 13, 2024 11:53

fix(angular-query) fixed eslint errors

ffa43a8

refactor(angular-query) set initial isRestoring to true to match th…

235bbab

…e React adapter logic

Revert "refactor(angular-query) set initial isRestoring to true to …

1f33c28

…match the React adapter logic" This reverts commit 235bbab.

fix(angular-query) fixed formatting of JSDOC comment ruined by eslint

23d6ee1

Merge branch 'main' into angular-persist-query-client-experimental

2e8bfe9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular persist query client experimental #8324

Angular persist query client experimental #8324

OmerGronich commented Nov 22, 2024 •

edited

Loading

nx-cloud bot commented Nov 22, 2024 •

edited

Loading

arnoud-dv left a comment

Angular persist query client experimental #8324

Are you sure you want to change the base?

Angular persist query client experimental #8324

Conversation

OmerGronich commented Nov 22, 2024 • edited Loading

Angular Query Persister Plugin

nx-cloud bot commented Nov 22, 2024 • edited Loading

☁️ Nx Cloud Report

arnoud-dv left a comment

Choose a reason for hiding this comment

OmerGronich commented Nov 22, 2024 •

edited

Loading

nx-cloud bot commented Nov 22, 2024 •

edited

Loading