Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing, linting, cleanup #1361

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Typing, linting, cleanup #1361

wants to merge 13 commits into from

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Dec 24, 2024

Fixes made while attempting to deal with #1244

is prefs.cache_list unused and safe to be removed?
it looks to be called once from a module to init a cache list, and loaded from save[170], but it is never set.

  • Make spot_ctl and tidal always belong to Tauon class instead of duping them globally too, this enables us to set them directly without having to check for None types
    • The code (both pre and post PR) looks as if Tidal is a hard dependency, was this intended, or am I reading it wrong?
  • Remove want_reconnect in phazor - it did nothing.
  • Start using stdbool.h in phazor and convert relevant ints to bool.
  • Make phazor require C17 at minimum(2018), and prep for requiring C23 - which just came out in 2024-10 so best give it some time - that one adds nice features like... bool

@C0rn3j C0rn3j marked this pull request as ready for review December 24, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant