Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyinstaller builds for macOS and Linux in the CI #1348

Merged
merged 97 commits into from
Dec 20, 2024

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Dec 17, 2024

Based on groundwork by @esaruoho - thanks!

This PR builds macOS and Linux pyinstaller images in the CI.
Adds a button to the GUI that toggles the console.
Some small typing cleanups and moving logging classes to a separate module.

DMGs are available in the Summary section of the CI Actions.

You can also click the green checkmark on the latest commit to find the current version yourself - you need to be logged in to GitHub for either.

To run through terminal for logs, you should be able to double click the unzipped DMG to mount it and then it'll be under Volumes
image

Fixes parts of #577*, Fixes #1129, Checks two boxes in #1315
* Note that tauon.py mentioned in old instructions is src/tauon/__main__.py nowadays.


TODO:

  • Linux:
    Gtk-Message: Failed to load module "colorreload-gtk-module"
    Gtk-Message: Failed to load module "window-decorations-gtk-module"
  • macOS: jxlpy won't build due to Does not build on ARM CPU olokelo/jxlpy#25
  • Check Tekore is being picked up (needs someone with Spotify Premium)
  • Make sure we're not dupe-packing assets, theme and templates - they could theoretically be packed in the executable.
  • Spec files have hardcoded Python 3.13
  • We're packing entire pysdl2-dll instead of just the two modules we need - how much filesize is it that we could save, does it matter?

WONTFIX:

  • UI with macOS system buttons jumps and overlaps Tauon elements when resizing at specific sizes - I do not have a Mac to test on, so this can be fixed by someone else in another PR

DONE (hopefully):

@C0rn3j C0rn3j changed the title Build for macOS pyinstaller builds for macOS and Linux in the CI Dec 19, 2024
@C0rn3j C0rn3j marked this pull request as ready for review December 20, 2024 12:40
@Taiko2k Taiko2k merged commit 51854aa into Taiko2k:master Dec 20, 2024
3 checks passed
@C0rn3j C0rn3j deleted the macos-dmg branch December 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python-tekore error
2 participants