-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Automatic Support to Not Use Multipart Uploads If File Size <= partSize
#387
base: master
Are you sure you want to change the base?
Conversation
… this option to `false` so that existing specs pass
…lete requests do not fire but the callbacks do
… when used for files of one part. This new class simply resolves its promise rather than make any requests
…bled and the file has only one part.
Hey @bikeath1337, so I found some time to try this out and plugged this branch into our code. However I am getting I'll try a simpler example to see if that works. EDIT: Yeah I seem to be getting the same for the simple example. Let me dig into it some other time again 😛 |
Hi, @jakubzitny , I'm back from being away... :) Any update on this? |
Hey there! I know this is SUPER old, but for anyone trying to do the same thing => I applied this changes to the evaporate lib in my project in order to improve performance a little bit and, hopefully, get rid of a sporadic bug in an already deprecated ( 😞 ) MinIO gateway, and I figured the The string to sign generator uses |
Thanks to @jakubzitny for #362.
This PR has not be tested yet, but specs pass (I will remove the WIP after doing more testing).
What this intends to do: Enhance Evaporate to avoid the overhead of using multipart uploads if the file size is equal to the part size. This option avoids two round trips to AWS (initiate and complete).
Description:
enablePartSizeOptimization
started
,progress
andcomplete
callbacks should all be invokedcomputeContentMd5
should be respectedChanges:
xhr
parameter will beundefined
.