SharpAudio #3619
Closed
SharpAudio #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TASEmulators fork + submodule sounds the sanest. |
…ns, audio playback doesn't work and crashes half the time, and OpenAL crashes because ???
|
After further use of this library, I don't think this is a good choice for us. In debugging I found multiple issues throughout the library, some of which seem to just indicate the lack of actual use (e.g. OpenAL disposing will always crash due to faulty dispose code). Using Vortice directly seems to be a better option for our needs (for XAudio2 at least). This isn't a complete loss at least, the device enumeration issue has been figured out, and was using Vortice's bindings so it would be a copy paste to port it over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knocks out audio stuff from SlimDX/OpenTK to one package (see #2261). See here for the modifications done: https://github.com/CasualPokePlayer/SharpAudio/tree/netstandard20. Dunno what to do with the modified fork in terms of the BizHawk repo (should it just be slapped in a submodule? a link just placed somewhere? should it go to TASEmulators org?). Leaving this draft for now (as far as I can tell though it just works)
EDIT: Also CI fails for whatever reason lol
EDIT2: It might actually not work, after a rebuild it is failing for me. I suspect actually it's related to the latest commit which I am yet checking, I would guess things were not getting rebuilt properly so it was still using old code?