Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage fixes #710

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

KrisThielemans
Copy link
Member

coveralls and codecov were broken.

fixes #709

Kris Thielemans added 2 commits June 6, 2020 23:28
coverage was broken in a few ways:
- .coverage was in a different place than we thought
- OSX sed doesn't support -r but needs -E
- we were not necessarily using the correct python
fixes SyneRBI#709
@KrisThielemans KrisThielemans requested a review from casperdcl June 6, 2020 22:35
@KrisThielemans
Copy link
Member Author

Location is fine now. However, at least 2 problems:

    Generating coverage xml reports for Python
    Error running `['/usr/bin/python3', '-m', 'coverage', 'xml', '-i']`: Command '['/usr/bin/python3', '-m', 'coverage', 'xml', '-i']' returned non-zero exit status 1
    - Ignored: [Errno 2] No such file or directory: '/home/travis/build/SyneRBI/SIRF/coverage.xml'
Error: No coverage report found
0.19s$ $PY_EXE -m coveralls
Submitting coverage to coveralls.io...
Traceback (most recent call last):
  File "/home/travis/.local/lib/python3.5/site-packages/coverage/sqldata.py", line 1048, in execute
    return self.con.execute(sql, parameters)
sqlite3.DatabaseError: database disk image is malformed
....
coverage.misc.CoverageException: Couldn't use data file '/home/travis/build/SyneRBI/SIRF/.coverage': database disk image is malformed

Possibly both of these have the same cause. I wonder if this is because .coverage is an SQLite database, and the sed corrupts it (quite likely as it has tons of \0).

Oh well.

@KrisThielemans
Copy link
Member Author

Seems that this fixed the OSX command argument and python issues.

On OSX, sed says explicitly that this is a binary file
https://travis-ci.org/github/SyneRBI/SIRF/jobs/695522266#L28294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverage and codecov
2 participants