Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional email service proper handling #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

that-one-arab
Copy link

Description:

As per the docs, email service should be optionally provided.

But the code requires it.

If we do not provide it, an exception is raised due to missing environment variables

If we provide it with incorrect values (such as the values in the example .env we get error TypeError: Converting circular structure to JSON when we try to login using google oauth.

This error, when traced, is due to the below request error sent to api.convertkit.com

data: { error: 'Authorization Failed', message: 'API Key not valid' }

This is how the request URL looks like https://api.convertkit.com/v3/tags/YOUR_LIST_ID/subscribe?api_secret=UNIQUE_SECRET_FROM_YOUR_CONVERTKIT_ACCOUNT&[email protected]&first_name=my-name so an error is expected to happen here.

This PR handles the aforementioned case

Adding Feature(s):

  • Make email service optional.

Fixing Issue(s):

  • Error during oauth sign in due to incorrect email environment variables

Changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant