Optional email service proper handling #194
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As per the docs, email service should be optionally provided.
But the code requires it.
If we do not provide it, an exception is raised due to missing environment variables
If we provide it with incorrect values (such as the values in the example .env we get error
TypeError: Converting circular structure to JSON
when we try to login using google oauth.This error, when traced, is due to the below request error sent to
api.convertkit.com
This is how the request URL looks like
https://api.convertkit.com/v3/tags/YOUR_LIST_ID/subscribe?api_secret=UNIQUE_SECRET_FROM_YOUR_CONVERTKIT_ACCOUNT&[email protected]&first_name=my-name
so an error is expected to happen here.This PR handles the aforementioned case
Adding Feature(s):
Fixing Issue(s):
Changes