🐛 Fix: Remove console error in dev tools #160
Conversation
Now the new way of using the `useFloating` hook is applied. See https://floating-ui.com/docs/useFloating
|
Hey @DiegoMutre , thanks for another PR. What are the breaking changes you're seeing? |
Hey, @tyler-dane. As you can see, the way of how the useFloating hook is used in the useEventForm is different than how it was used before the upgrade. That's the only change I noticed because the I haven't checked the changelog carefully of floating-ui to notice any other change. But, regarding the someday event form, everything works fine. |
OK cool. It sounds like you just needed to adjust how we're using the library to conform to their new APIs, but that no functionality from a user perspective changed. If that's the case, then the only things that's missing are those other comments I left. |
Hey, @tyler-dane. I'm sorry, I don't understand what you mean by comments left. |
|
Hey, I'm just asking that you follow up on the PR comments I left about
the eslint warnings
…On Wed, Nov 6 2024 at 6:59 AM, Martinn ***@***.***> wrote:
I haven't checked the changelog carefully of floating-ui to notice any
other change. But, regarding the someday event form, everything works fine.
OK cool. It sounds like you just needed to adjust how we're using the
library to conform to their new APIs, but that no functionality from a user
perspective changed.
If that's the case, then the only things that's missing are those other
comments I left.
Hey, @tyler-dane <https://github.com/tyler-dane>. I'm sorry, I don't
understand what you mean by comments left.
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGEA3323SVAABHFIJOITKLZ7IHEDAVCNFSM6AAAAABRDAG6AGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZGY4TCMBSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Unassigning due to inactivity |
This fixes #156.
The idea of updating to the latest version came from this issue floating-ui/floating-ui#2534
Further testing is welcome because there are some breaking changes by upgrading @floating-ui/react to the latest version as you can see.