Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop setup-swift (for Linux, which is the prod platform) #43

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

finestructure
Copy link
Member

@finestructure finestructure commented Jun 8, 2023

This drops our setup-swift dependency. While it's a nice tool to set up Swift versions across platforms, it doesn't support pre-release versions (nightlies) and therefore makes it harder for us to add them overall before Swift versions are final.

This change itself does not yet switch to a nightly, that's going to be a separate PR.

@cla-bot cla-bot bot added the cla-signed label Jun 8, 2023
@@ -52,3 +46,30 @@ jobs:

- name: Check dependencies
run: ./check-dependencies.sh

# test-validator-macOS:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've disabled the macOS test, because we're running validation on Linux and this platform test was just around because it was easy to do via setup-swift. Since we're now dropping it, maintaining the macOS test would be complicated.

@finestructure finestructure marked this pull request as ready for review June 8, 2023 11:19
@finestructure finestructure marked this pull request as draft June 8, 2023 11:30
@finestructure
Copy link
Member Author

Going back to draft for now, because in order for this to work end-to-end, we also need to eliminate setup-swift from package list validation. Which is a bit tricky, because running swift in a docker container while managing output files can be problematic and we need to test this first.

Copy link
Member

@daveverwer daveverwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping a tick so you can merge, but understood about docker and testing first.

@finestructure
Copy link
Member Author

Ok, this is actually working very seamlessly when running it in containers: https://github.com/SwiftPackageIndex/PackageList/actions/runs/5212521427/jobs/9406276077 (job succeeded, just cancelled out of it because it'd run for ages)

@finestructure finestructure marked this pull request as ready for review June 8, 2023 14:53
@finestructure finestructure merged commit 231a085 into main Jun 8, 2023
2 checks passed
@finestructure finestructure deleted the drop-setup-swift branch June 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants