Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit landing page #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Edit landing page #13

wants to merge 2 commits into from

Conversation

tnxk19
Copy link

@tnxk19 tnxk19 commented Oct 26, 2024

  • Create header
  • Create footer ( link to your social media)
    and and some more I will do later...

- Create header
- Create footer ( link to your social media)
Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tictactoe ❌ Failed (Inspect) Oct 31, 2024 5:55am

@SusheelThapa
Copy link
Owner

@tnxk19 Thank you so much for you contribution

Overall,The Landing Page look nice.

Here are few suggestions:

  • Could you decrease the size of the Header Text.
  • Also, Could you create about section, gameplay, FAQ and contact section below the Hero Section.
  • Additionally, Could you include the github icon/button on the right side of the header.

@SusheelThapa SusheelThapa self-assigned this Oct 26, 2024
@SusheelThapa SusheelThapa linked an issue Oct 26, 2024 that may be closed by this pull request
2 tasks
@tnxk19
Copy link
Author

tnxk19 commented Oct 26, 2024

Screenshot 2024-10-26 230433
What is this error and how can I fix it?

@SusheelThapa
Copy link
Owner

Screenshot 2024-10-26 230433 What is this error and how can I fix it?

The error is from our side. Actually, I have configure Greeting.yml so that whenever new user open issue or pull request, They will be greeting message. Unfortunately, it is misconfigured.

@SusheelThapa
Copy link
Owner

@tnxk19 You can check Header.tsx files inside the components/ folder which I have build in past.

Also, the icon i have used is kinda no good, so make sure to replace with your icon if you are going to use that.

- Edit Home page
- Add About page
- Add Gameplay page
- Add link to FAQ
- Add Contact page.
@tnxk19
Copy link
Author

tnxk19 commented Oct 31, 2024

Edit landing page (2)

  • Edit Home page
  • Add About page
  • Add Gameplay page
  • Add link to FAQ
  • Add Contact page.

@SusheelThapa
Copy link
Owner

Thank you so much for the changes.

In the Gameplay, could you add the content on the respective section and I can see the scroll bar which might be result of the margin and padding

/faq route is not working

Horizontal scroll bar in the contact us page, and decrease the size of the contact us form.

Also, I have attached the vercel error that has been encountered.
Uploading Screenshot from 2024-11-05 11-11-50.png…

@SusheelThapa
Copy link
Owner

Additionally, you can run the command npm run build to check for any error in the production. If you get any error then try to fix that error else everything is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhanceent] Landing page for the project
2 participants