Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where twitter/x usernames with _ would result in null #743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harsimran-d
Copy link

@harsimran-d harsimran-d commented Sep 15, 2024

What does this PR do?

update the regex for extractTwitterUsername to include '_'

Where should the reviewer start?

start in src/features/talent/utils/extractUsername.ts

How should this be manually tested?

as described in the linked issue #742

Any background context you want to provide?

twitter/x usernames do allow '_'
My own username of harsimran_d was resulting in null although its perfectly valid

What are the relevant issues?

Closes #742

Screenshots (if appropriate)

Copy link

vercel bot commented Sep 15, 2024

@harsimran-d is attempting to deploy a commit to the Superteam Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding X.com handle with '_' results to null
1 participant