Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker #667

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from
Open

Added Docker #667

wants to merge 11 commits into from

Conversation

ArpitBlagan
Copy link

@ArpitBlagan ArpitBlagan commented Jul 26, 2024

What does this PR do?

Added docker file for quick setup

Where should the reviewer start?

How should this be manually tested?

simply create the .env file and run docker compose up

Any background context you want to provide?

No

What are the relevant issues?

NA

Screenshots (if appropriate)

Screenshot 2024-07-27 at 12 38 42 PM

Copy link

vercel bot commented Jul 26, 2024

@ArpitBlagan is attempting to deploy a commit to the Superteam Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@a20hek a20hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested this by setting up the project only using docker, with these commands?

@ArpitBlagan
Copy link
Author

ArpitBlagan commented Jul 27, 2024

have you tested this by setting up the project only using docker, with these commands?

Yes, just need to create .env file and database url also there in readme.md and run migrate command locally as there is no migration file in prisma and run docker compose up and also implement dark mode can push the changes in this pr
Screenshot 2024-07-27 at 12 04 34 PM
Screenshot 2024-07-27 at 12 03 52 PM

@ArpitBlagan
Copy link
Author

have you tested this by setting up the project only using docker, with these commands?

??

@a20hek
Copy link
Member

a20hek commented Jul 30, 2024

have you tested this by setting up the project only using docker, with these commands?

??

no need to implement dark mode.
i just want you to start this project from scratch and test if everything works alright

@ArpitBlagan
Copy link
Author

have you tested this by setting up the project only using docker, with these commands?

??

no need to implement dark mode. i just want you to start this project from scratch and test if everything works alright

okY

@ArpitBlagan
Copy link
Author

have you tested this by setting up the project only using docker, with these commands?

??

no need to implement dark mode. i just want you to start this project from scratch and test if everything works alright
we need to first run migration locally then the docker compose up
here is the demo:
https://www.loom.com/share/7c45c4a2841448b39eff164d20151572?sid=f84eb343-3772-4f71-867f-0a08d19538ca

@ArpitBlagan
Copy link
Author

ArpitBlagan commented Aug 3, 2024

have you tested this by setting up the project only using docker, with these commands?

??

no need to implement dark mode. i just want you to start this project from scratch and test if everything works alright

check now @a20hek
we just need two steps create .env and run docker compose up please check it out.

@a20hek
Copy link
Member

a20hek commented Aug 16, 2024

but you are still adding commits @ArpitBlagan
can you explain these?

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 6:58am

@ArpitBlagan
Copy link
Author

but you are still adding commits @ArpitBlagan can you explain these?

Yes previously I am first creating the migration file first and then run docker compose but then I findout that we don't need to do that so I just updated that

@a20hek a20hek changed the base branch from main to staging August 17, 2024 21:13
package.json Outdated
@@ -4,6 +4,7 @@
"private": true,
"scripts": {
"dev": "cross-env NODE_ENV=development next dev",
"docker-dev": "pnpm prisma push db && pnpm run dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong command; its pnpm prisma db push

i did confirm if you checked once..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/SuperteamDAO/earn/blob/main/CONTRIBUTING.md#making-a-pull-request
also please check the option for allowing edits from maintainers

Copy link
Author

@ArpitBlagan ArpitBlagan Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong command; its pnpm prisma db push

i did confirm if you checked once..

yes, there was a typo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/SuperteamDAO/earn/blob/main/CONTRIBUTING.md#making-a-pull-request also please check the option for allowing edits from maintainers
sorry I am getting confused here if you are talking about
the checkbox for allow edits from maintainers it is already checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants