-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: misc ui changes (Gitcoin) #14
Conversation
@JeremiGendron awesome! already approved on Gitcoin, gonna check this out ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeremiGendron just saw your changes, could you please:
- Revert the
<Divider />
and style of thedrawerHeader
(that wasn't part of the bounty issue) - Finish fixing remaining buttons (the circular ones, part of the bounty issue)
- Fix whitespace/margin left to the main content (also part of the bounty issue)
@benoror which remaining buttons? The profile + circularIcon button gets unstyled when it's not a button anymore. Contacts? Or UI like (+) buttons. |
These buttons: |
Ok, on it
…On Sun, Nov 25, 2018, 12:32 PM Ben Orozco ***@***.*** wrote:
@benoror <https://github.com/benoror> which remaining buttons? The
profile + circularIcon button gets unstyled when it's not a button anymore.
Contacts? Or UI like (+) buttons.
These buttons:
<https://camo.githubusercontent.com/9eb0cee4404c84943150179a44f64afa2c3d4225/687474703a2f2f672e7265636f726469742e636f2f4459765a574c4432676e2e676966>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AWfqZReeChzauASz5ILpLurkAmKwCkk7ks5uytQ0gaJpZM4Yxl3T>
.
|
@benoror I'm not sure whether you want Text-only or Icon next to text for those, so I will not continue with the bounty. Submitting clean PR with changes so far. |
@benoror Nevermind! Looks like you took it into your own hands. |
@JeremiGendron I would be glad to commit long term for the project if I like what I see... I need a design-driven React expert. btw, did you try running the app? You need to sign in using Blockstack: http://blockstack.org |
I'm not an expert, but I can get the job done. I have a lot of time too. |
Awesome, please stick with the requirements for now, and feel free to improve other areas as well. Thanks! |
2bea759
to
966d18f
Compare
Hey, saw #13 and thought I'd give it a shot.
These fixes should make you happy.