Canvas backend and module functors #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikochiko
reviewed
Mar 11, 2024
Comment on lines
+24
to
+54
| module type Backend = sig | ||
| type context | ||
|
|
||
| val context : context option ref | ||
|
|
||
| type 'a point = 'a Shape.point | ||
| type shape = Shape.shape | ||
| type shapes = Shape.shapes | ||
| type transformation = Transform.transformation | ||
| type color = Color.color | ||
|
|
||
| val point : int -> int -> float Shape.point | ||
| val circle : ?c:float Shape.point -> int -> Shape.shape | ||
| val rectangle : ?c:float Shape.point -> int -> int -> Shape.shape | ||
| val polygon : float Shape.point list -> Shape.shape | ||
| val ellipse : ?c:float Shape.point -> int -> int -> Shape.shape | ||
| val line : ?a:float Shape.point -> float Shape.point -> Shape.shape | ||
| val complex : Shape.shape list -> Shape.shape | ||
| val rotate : int -> Transform.transformation | ||
| val scale : float -> Transform.transformation | ||
| val translate : int -> int -> Transform.transformation | ||
| val with_stroke : color -> shape -> shape | ||
| val with_fill : color -> shape -> shape | ||
| val map_stroke : (color -> color) -> shape -> shape | ||
| val map_fill : (color -> color) -> shape -> shape | ||
| val white : color | ||
| val black : color | ||
| val red : color | ||
| val blue : color | ||
| val green : color | ||
| val yellow : color |
There was a problem hiding this comment.
This API should not be customisable.
I am working on a change where we can add the module functor you wrote for Impl (with fewer of those functions).
nikochiko
reviewed
Mar 11, 2024
Comment on lines
+10
to
+14
| (* Renders context to PNG *) | ||
| let write ctx filename = | ||
| Cairo.PNG.write ctx.surface filename; | ||
| Cairo.Surface.finish ctx.surface | ||
|
|
There was a problem hiding this comment.
This only renders PNG, not SVG.
Moreover, we should not use Cairo for SVG - even if it does support that - because we want to be able to run SVG backend in the browser. Cairo will need the native library to be installed.
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the HTML canvas backend and added module functors so that backends can be created easily.
I went with JSOO as Melange seems immature and documentation is less than ideal. It was unclear how Melange would integrate with a library that targets both native and the browser.
Adding new backends should now be easy as there's a
Joymodule functor that takes aBackendmodule signature and injects geometry/transformation/types modularly. The Cairo backend is now available under Joy.SVG and the canvas backend Joy.Canvas.