Fix scaling factor in scale transform #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FayCarsons
pushed a commit
to FayCarsons/ocaml-joy
that referenced
this pull request
Jan 19, 2024
* Fix scaling factor: shouldn't be sqrt * Format with dune * Add donut-with-scaling example
FayCarsons
pushed a commit
to FayCarsons/ocaml-joy
that referenced
this pull request
Jan 26, 2024
* Fix scaling factor: shouldn't be sqrt * Format with dune * Add donut-with-scaling example
FayCarsons
pushed a commit
to FayCarsons/ocaml-joy
that referenced
this pull request
Feb 16, 2024
* Fix scaling factor: shouldn't be sqrt * Format with dune * Add donut-with-scaling example
nikochiko
added a commit
that referenced
this pull request
Feb 16, 2024
* first draft color system * rewriting examples * dune fmt * add proposal for color transforms * Add example with rectangular canvas (for testing) (#87) A circle in a rectangular canvas should not become an ellipse. * Fix scaling factor in scale transform (#88) * Fix scaling factor: shouldn't be sqrt * Format with dune * Add donut-with-scaling example * more merging ?? * merging w/ main branch * added stroke and fill fields, 'with' fns to add them to shapes, and map fns for applying fns to those fields * applying suggestions and adding map_color fns * remove map_color * change docstring phrasing, fix .mli files * fixing merge issues --------- Co-authored-by: Kaustubh Maske Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.