Implemented Polygon type + refactored Rectangle to make use of it #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikochiko
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks @FayCarsons for the changes!
I've suggested some changes:
- the previous
Rectangleconstructor can be removed entirely because it doesn't hold enough data - the
rectanglefunction can keep having the same interface and we calculate the polygon points from the arguments
|
Fixed conflicts & applied suggestions. Ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #59
Implemented N-sided polygon type, functions, etc. Not covered in 'scale' because implementation may change soon. Refactored rectangle to be a specific case of a 4-sided polygon so that it may be transformed more easily. Exposed 'point' type to make polygon construction easier and for destructuring etc in sketches.