-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the rotation transformation function and examples #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! @nangahamandine
I've added some comments.
Thanks for the additional comments throughout the code. Can you add them in another PR please and remove them from here? It's a cleaner commit history that way, and it also makes it easier to do better reviews.
Thank you. I'll take out the comments and update the code. |
1 similar comment
Thank you. I'll take out the comments and update the code. |
I've updated the code based on all the requested changes made by @nikochiko I encountered some issues with refactoring into a rotate_point function and when using pattern matching, hence the delay. Please review :) |
…to rotation-refactor
Awesome! I'm glad you were able to do it. I added comments where I thought the changes weren't necessary. At this point because our representation of rectangle / ellipse is not good enough, we aren't able to demonstrate rotation in examples properly. Once that is done we should be able to create more interesting examples! |
Thank you @nikochiko
I'm not sure where, can you please reiterate so I could make the necessary changes.
|
All rotation transformations are now displayed within the canvas
These changes are based on the requirements of issue #60