Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG backend #133

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add SVG backend #133

wants to merge 6 commits into from

Conversation

nikochiko
Copy link
Collaborator

  • Refactor and rename: backends, cairo, contexts
  • Remove axes from square
  • Fix bug with rendering axes
  • Add comment for axes.ml
  • Run dune fmt
  • Default line_width to 1 for cairo
  • Remove stale comment for backend_cairo.ml
  • Run dune fmt
  • Re-add base to joy.opam
  • Add SVG backend

@nikochiko nikochiko changed the title svg Add SVG backend Mar 12, 2024
@FayCarsons
Copy link
Collaborator

Cairo has the ability to render to SVGs and PNGs simultaneously, maybe sticking to that to reduce redundancy and take advantage of those features may be a better path?

I have some other thoughts as well, will add reviews later

@nikochiko
Copy link
Collaborator Author

That won't work because we want to compile to browser. Cairo bindings won't be available in the browser.

@FayCarsons
Copy link
Collaborator

Are you trying to render SVG files that can be downloaded from the browser, or attach SVG elements to the DOM so they can be viewed in-browser?

@nikochiko
Copy link
Collaborator Author

Are you trying to render SVG files that can be downloaded from the browser, or attach SVG elements to the DOM so they can be viewed in-browser?

To attach elements to the DOM - so they can be viewed in browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants