Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix entitySlot entities under PrefabPlaceholders #2128

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

killzoms
Copy link
Collaborator

@killzoms killzoms commented Apr 3, 2024

fixes #1948

@tornac1234 tornac1234 added Type: bug Area: spawning Related to spawning and/or terrain labels Apr 29, 2024
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CW
Needs in game testing with rejoining and server restarting

@killzoms killzoms force-pushed the prefabPlaceholderFix branch from 774a28d to 64cf380 Compare December 24, 2024 11:01
@killzoms killzoms requested a review from Jannify December 24, 2024 11:01
@killzoms
Copy link
Collaborator Author

rebased on the latest changes and fixed a couple of minor issues. Floating Stones should look and function as they typically do in Vanilla Subnautica now. Fragments aren't 100% vanilla yet as there is currently no filtering based on finished Scan progress, that is out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: spawning Related to spawning and/or terrain Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIG Crabsnakes
3 participants