Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(player): add seek action and handle seeking player state #645

Merged
merged 17 commits into from
Nov 28, 2024
Merged

feat(player): add seek action and handle seeking player state #645

merged 17 commits into from
Nov 28, 2024

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented May 16, 2024 •
edited by kKaskak
Loading

@elpiel elpiel requested a review from tymmesyde May 16, 2024 16:39
@elpiel elpiel requested a review from kKaskak November 18, 2024 12:54
@kKaskak kKaskak added the core stremio-core related label Nov 18, 2024
kKaskak
kKaskak previously approved these changes Nov 18, 2024
View reviewed changes
@kKaskak kKaskak self-requested a review November 18, 2024 13:55
kKaskak
kKaskak previously approved these changes Nov 18, 2024
View reviewed changes
@elpiel elpiel changed the title feat(player): add seek action and handle seeking player state w/ debug statements feat(player): add seek action and handle seeking player state Nov 19, 2024
tymmesyde
tymmesyde requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@tymmesyde tymmesyde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i play the video and start to seek using the seekbar, the seek action will still be sent after stopping

@tymmesyde tymmesyde merged commit 9ea6c82 into development Nov 28, 2024
2 checks passed
@elpiel elpiel deleted the feat/seek-player-action branch December 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde requested changes

@kKaskak kKaskak kKaskak approved these changes

Assignees

@elpiel elpiel

Labels
core stremio-core related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpiel @tymmesyde @kKaskak