-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docker image #526
base: development
Are you sure you want to change the base?
Improve docker image #526
Conversation
a3cf12c
to
6a14025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The only difference is that we dont have a custom 404 page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we need the 404 handler for sure, which we will customize later
The current dockerfile does not have a custom 404 page either, it just has a comment saying it should be added later. To add a custom 404 page, a |
Have you considered using caddy instead? Also has a 17mb base image size for caddy |
TLS should be handled by the user IMO, gives them control of how they want to do it. The purpose of the Docker image should just be to serve the static files and nothing more. As for the size, while ~16 MB difference does not matter, the base size of |
While I agree with the statement TLS should be handled by the user, I have to add it still would be. They'd still have to mount a caddy file to enable it, configure their load balancing, cache settings, rewrites etc if they wanted to opt into the features. The point is they'd have the option to. Just gives users who are hosting in something like azure container apps / instances, where they probably wouldn't want to pay for azure gateway or introduce a second container instance as a load balancer the ability to have easily opt-in features, with the use of a single file server rather than a static file server reverse proxied by a second file server. That's ok I did say "considered" 😛 |
http_server.js
Bechmark with 100k requests:
Before
After