Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(player): reset library item time offset if selected video don't match state #755

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Dec 23, 2024

When library item and selected is available, if the selected requested video_id doesn't match the state of the stored library item, update the item in the library to reset its timeOffset to 0

@tymmesyde tymmesyde requested review from elpiel and kKaskak December 23, 2024 14:28
Copy link
Member

@kKaskak kKaskak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with web and it works ✅

@jaruba jaruba self-requested a review December 23, 2024 15:10
@jaruba
Copy link
Member

jaruba commented Dec 23, 2024

tested, works fine

@tymmesyde tymmesyde merged commit 095fb3e into development Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants