Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: player next stream #536

Merged
merged 6 commits into from
Oct 24, 2023
Merged

feat: player next stream #536

merged 6 commits into from
Oct 24, 2023

Conversation

tymmesyde
Copy link
Member

No description provided.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR remove the need to go through the MetaDetails model before loading the next (suggested) stream (i.e. #527) ?

Basically the same suggested stream should be returned from the Player itself I suppose.

This leads me to another question: What about the StreamsBucket? Shouldn't we update the Player model to also takes care of adding the Stream to the StreamsBucket?
Right now on Player::Load it adds the selected stream to the StreamBucket but I'm not sure if we should do this beforehand when selecting next_stream.

}

fn fetch_handler(request: Request) -> TryEnvFuture<Box<dyn Any + Send>> {
println!("{:?}", request.url);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this println

@elpiel elpiel requested a review from TheBeastLT October 13, 2023 06:49
@tymmesyde
Copy link
Member Author

Does this PR remove the need to go through the MetaDetails model before loading the next (suggested) stream (i.e. #527) ?

I'm not sure, we should discuss it

Basically the same suggested stream should be returned from the Player itself I suppose.

Right, either we return the next_stream object in our different implementations of core or use it to build deep links for next_video

This leads me to another question: What about the StreamsBucket? Shouldn't we update the Player model to also takes care of adding the Stream to the StreamsBucket? Right now on Player::Load it adds the selected stream to the StreamBucket but I'm not sure if we should do this beforehand when selecting next_stream.

I'm not sure if it's an issue

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's discuss this with @TheBeastLT in Slack and see if the other applications that go through the MetaDetails first to keep the history navigation correct should remain or we should use the next_stream of this PR

@elpiel
Copy link
Member

elpiel commented Oct 23, 2023

Related #397

  • We should also add the bindge watch group when loading the next_streams It's better to keep them all and filter accordingly to out needs

@elpiel elpiel merged commit 6189624 into development Oct 24, 2023
1 check passed
@elpiel elpiel deleted the feat/player-next-stream branch October 24, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants