Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_move_request does not seem like doing anything #3

Open
Xi-HHHM opened this issue Oct 1, 2023 · 1 comment
Open

send_move_request does not seem like doing anything #3

Xi-HHHM opened this issue Oct 1, 2023 · 1 comment

Comments

@Xi-HHHM
Copy link

Xi-HHHM commented Oct 1, 2023

velocity_scaling_factor = self.default_velocity_scaling_factor

Only a variable of the velocity factor is defined.

@Xi-HHHM
Copy link
Author

Xi-HHHM commented Oct 1, 2023

I generally don't like the coding style of the robot client (and I generally don't say it out loud). It might be okay for self-development, but it is not team-friendly at all since the majority of functions do not have a doc string to explain what this function does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant