-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To keep the selected li visible under the dropdown, using keyboard up/down arrow keys when a large number of options are available. #83
Open
shivarchit
wants to merge
81
commits into
3.5
Choose a base branch
from
master
base: 3.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in ie9 and probably (ie10) when you click on an option in the pulldown menu the focus of the editor is lost and the selected option can not be added to the tinymce editor. This single line fixes this issue.
added focus in select function for IE
… field in the source option
Insert function can use a different value than the queryBy field. (insertFrom)
Define sorter as option to override the default 'sorter' function
Use HTTPS connection for loading spinner to prevent mixed content
It can be useful when we want to set a different HTML according to the item position. Here is an example to active the first item: render: function(index, item) { return '<li' + (index == 0 ? ' class="active"' : '') + '>' + '<a href="javascript:;"><span>' + item[this.options.queryBy] + '</span></a>' + '</li>'; } Signed-off-by: Nicolas Dos Santos <[email protected]>
…ine is impossible when there is already text on this line In the prevCharIsSpace function, 'start' variable can be lower than 0, so it computes a substring with a negative value as first argument
update the render function to add the item index in argument.
Adding a new mention at the beginning of a line is impossible when there is already text on this line
Fixed bug where last highlighted item was being added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'd a requirement which wanted me to keep the selected option always visible in the dropdown when using the keyboard up/down keys. I have added a change which now allows me to change the scroll and keep the selected option visible.