Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REP 145 improvements regarding bias estimation and gravity compensation #1

Open
wants to merge 3 commits into
base: rep_145_steve
Choose a base branch
from

Conversation

peci1
Copy link

@peci1 peci1 commented Mar 15, 2023

No description provided.

@@ -65,6 +65,8 @@ Data Sources
- The accelerometers report linear acceleration data expressed in the sensor frame of the device. This data is output from the driver as a 3D vector, representing the specific force acting on the sensor.

- When the device is at rest, the vector will represent the specific force solely due to gravity. I.e. if the body `z` axis points upwards, its `z` axis should indicate +g. This data must be in m/s^2.

- Specific force is the non-gravity-induced acceleration of a body (or acceleration "relative to" free fall). That is why the specific force of a body in rest is +g (the specific force must be the opposite of gravity to keep the body in rest). Specific force of a free falling body is zero.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads like a definition, but isn't a specification. The sentence above states that "the vector will represent the specific force solely due to gravity" which means I guess that in this spec, we have already stated they must contain gravity

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this paragraph mostly as a quick explainer distilled from Wikipedia for readers who do not know much about specific forces. So it is not meant as a specification. You are right that there is overlap with the previous paragraph.

What about this condensation of the 3 paragraphs into 2?

  • The accelerometers report linear acceleration data expressed in the sensor frame of the device. This data is output from the driver as a 3D vector, representing the specific force acting on the sensor. This data must be in m/s^2.

  • [Definition] Specific force is the non-gravity-induced acceleration of a body (or acceleration "relative to" free fall). That is why the specific force of a body in rest is +g (the specific force must be the opposite of gravity to keep the body in rest). Specific force of a free falling body is zero.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, this is on a hiatus for me given the recent changes in employment. Need to baton down the hatches a bit and revisit things like this once I know what's going on

Copy link
Author

@peci1 peci1 Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that, Steve. Would you be willing to merge this PR as is to ros-infrastructure#372, so that the discussion is not so fragmented? Alternatively, I could open a new PR for the REP and transfer all the activity there and drag the cart for a while instead of you ;) What do you prefer?

I was looking for a way to transfer an existing PR, but it seems not possible on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants