add multi-platform docker image #292
Conversation
|
Wow, I really like this. I can't speak for the maintainers, but I plan to use it myself. One bit of feedback: The GitHub diff shows a bunch of files where almost everything is changed, but I suspect what's happening is that some newlines got switched from DOS to Unix style. As much as I appreciate that change and generally prefer to see Unix newlines in things, if you can avoid changing newline styles and making functional changes in the same PR, it would make the diffs easier to read, review, and understand. |
|
This has merge conflicts with the latest Thanks again, @justgook for redoing the Docker images in the first place, and @Stephane-D for the incredible SGDK! |
Rebased, cleaned-up version of PR Stephane-D#292 Compared with Stephane-D#292, this: - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31) - has no changes to newline styless, so the diff is easier to read - adds instructions to readme.md on building deps/gcc.Dockerfile - fix case on gcc docker image (must be lowercase apparently) - fixes typos Resolves Stephane-D#290
|
@joeyparrish im happy, if you can continue on it.. i kid if switched to other projects.. and have no time for now to do those fine tuning.. |
|
@justgook, I am unable to make the multi-platform builds work in CI. The emulated arm64 build of GCC keeps hanging in GitHub's VMs. So my version will now have two commented-out sections in the workflow to re-enable arm64 at a later date. The rest seems to work, though. I went through the actions runs on your fork to see if this was a bug I introduced somehow, but I didn't see any successful runs of the GCC build there. Happy to have your input if you have any, but otherwise, I'm going to push forward with a single-platform workflow for now. |
|
as i remember it took few hours to build arm64 version of gcc on CI. and it will be like that until github will get native arm64 runners. I had success of building, but don’t remember how. as later i switched my focus to building all tools as part of pipeline, that builds all those tools using makefiles without docker. |
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that do not rely on Wine, with a GitHub Actions workflow to build and push Docker images to ghcr.io. Compared with Stephane-D#292, this: - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31) - has no changes to newline styless, so the diff is easier to read - adds instructions to readme.md on building deps/gcc.Dockerfile - fix case on gcc docker image (must be lowercase apparently) - fixes typos - streamlines and simplifies the GitHub Actions workflow - disables arm64 image builds because they keep hanging in the GitHub Actions environment Resolves Stephane-D#290
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that do not rely on Wine, with a GitHub Actions workflow to build and push Docker images to ghcr.io. Compared with Stephane-D#292, this: - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31) - has no changes to newline styless, so the diff is easier to read - adds instructions to readme.md on building deps/gcc.Dockerfile - fix case on gcc docker image (must be lowercase apparently) - fixes typos - streamlines and simplifies the GitHub Actions workflow - disables arm64 image builds because they keep hanging in the GitHub Actions environment Resolves Stephane-D#290 Resolves Stephane-D#304
Rebased, cleaned-up version of PR Stephane-D#292, which adds Docker images that do not rely on Wine, with a GitHub Actions workflow to build and push Docker images to ghcr.io. Compared with Stephane-D#292, this: - is based on 4397ac2 (2024-03-06) instead of d84d456 (2023-07-31) - has no changes to newline styless, so the diff is easier to read - adds instructions to readme.md on building deps/gcc.Dockerfile - fix case on gcc docker image (must be lowercase apparently) - fixes typos - streamlines and simplifies the GitHub Actions workflow - disables arm64 image builds because they keep hanging in the GitHub Actions environment Resolves Stephane-D#290 Resolves Stephane-D#304
Resolves #290